Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit e4ad808. Configure here.
| 'ms', // Malay | ||
| 'ne_NP', // Nepali (Nepal) | ||
| 'no', // Norwegian | ||
| 'nb', // Norwegian Bokmål |
There was a problem hiding this comment.
Norwegian Bokmål locale removed
Medium Severity
nb (Norwegian Bokmål) was dropped from SUPPORTED_LOCALES. That change is unrelated to the Chinese locale remapping in this PR, so translation tooling will stop treating Bokmål as a supported language and will no longer create or maintain nb.po files.
Reviewed by Cursor Bugbot for commit e4ad808. Configure here.
przemyslaw-zan
left a comment
przemyslaw-zan
left a comment
There was a problem hiding this comment.
Title is invalid. It's about the filename, not the "language code", and omits zh_CN → zh-hans and the nb removal. Suggested: Map zh_CN/zh_TW to zh-hans/zh-hant filenames and drop the nb locale.
| - https://github.com/ckeditor/ckeditor5-commercial/issues/10480 | ||
| --- | ||
|
|
||
| The `languageCode` returned for the `zh_CN` and `zh_TW` locales is no longer the ambiguous `zh` for both. It is now `zh-Hans` for `zh_CN` (Simplified Chinese) and `zh-Hant` for `zh_TW` (Traditional Chinese). |
There was a problem hiding this comment.
The changelog does not match the code. languageCode was not updated, only the filenames. The zh_CN and zh_TW locales now emit script-based translation files instead of the previous region/ambiguous names. (languageCode is unchanged — it stays zh, since it only drives plural-form selection.)
| 'ms', // Malay | ||
| 'ne_NP', // Nepali (Nepal) | ||
| 'no', // Norwegian | ||
| 'nb', // Norwegian Bokmål |
There was a problem hiding this comment.
This removal deserves a changelog entry.
2 participants
🚀 Summary
No longer map
zh_TWlanguage tozhlanguage code in dev translations.📌 Related issues